Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support function unnesting for json_as_text inner calls #57

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

davidhewitt
Copy link
Collaborator

Noticed this while investigating #53

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (6fae049) to head (0cb8be7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   84.69%   84.78%   +0.09%     
==========================================
  Files          15       15              
  Lines         980      986       +6     
  Branches      980      986       +6     
==========================================
+ Hits          830      836       +6     
  Misses        103      103              
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidhewitt
Copy link
Collaborator Author

I think the justification here is that at the moment for x->>a->>b, we only require x and x->>a to be text, which means that this works fine. In a world with a custom JSON type, we might require a JSON type as input, so x-->a returning a string (i.e. stripping the JSON-ness) would then cause the subsequent ->>b lookup to be invalid.

@davidhewitt davidhewitt merged commit 4446d2b into main Nov 28, 2024
7 checks passed
@davidhewitt davidhewitt deleted the dh/double-double-arrow branch November 28, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants