Skip to content

Commit

Permalink
Sqlx nav description requirement fix (#709)
Browse files Browse the repository at this point in the history
* sqlx-nav-descritpion-fix

* sqlx-nav-descritpion-fix
  • Loading branch information
Ekrekr authored Apr 22, 2020
1 parent 08b0547 commit d663776
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion core/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function mapColumnDescriptionToProto(
})
];
}
const columnDescriptor: dataform.IColumnDescriptor[] = description.description
const columnDescriptor: dataform.IColumnDescriptor[] = !!description
? [
dataform.ColumnDescriptor.create({
path: currentPath,
Expand Down
2 changes: 0 additions & 2 deletions tests/core/core.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,6 @@ suite("@dataform/core", () => {
type: "table",
columns: {
dimension_column: {
description: "Dimension description",
displayName: "Dimension",
dimension: "timestamp"
},
Expand All @@ -553,7 +552,6 @@ suite("@dataform/core", () => {
);
expect(dimensionColumn).to.eql(
dataform.ColumnDescriptor.create({
description: "Dimension description",
dimensionType: dataform.ColumnDescriptor.DimensionType.TIMESTAMP,
displayName: "Dimension",
path: ["dimension_column"]
Expand Down
2 changes: 1 addition & 1 deletion version.bzl
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# NOTE: If you change the format of this line, you must change the bash command
# in /scripts/publish to extract the version string correctly.
DF_VERSION = "1.5.5"
DF_VERSION = "1.5.6"

0 comments on commit d663776

Please sign in to comment.