Make overriding 'database' work for declarations. (#531)

core/session.ts

@@ -210,6 +210,7 @@ export class Session {
           return this.operate(actionOptions.sqlxConfig.name);
         case "declaration":
           return this.declare({
+            database: actionOptions.sqlxConfig.database,
             schema: actionOptions.sqlxConfig.schema,
             name: actionOptions.sqlxConfig.name
           });

examples/common_v2/definitions/example_declaration.sqlx

@@ -1,5 +1,6 @@
 config {
   type: "declaration",
+  database: "some_database_name",
   schema: "some_external_schema_name",
   name: "very_important_external_table",
   description: "This table is not generated by Dataform!"

tests/api/examples.spec.ts

@@ -394,10 +394,10 @@ describe("examples", () => {
         expect(exampleOperationWithOutput.queries).to.eql([
           `\nCREATE OR REPLACE VIEW \`tada-analytics.${schemaWithSuffix(
             "df_integration_test"
-          )}.example_operation_with_output\` AS (SELECT * FROM \`tada-analytics.some_external_schema_name.very_important_external_table\`)`
+          )}.example_operation_with_output\` AS (SELECT * FROM \`some_database_name.some_external_schema_name.very_important_external_table\`)`
         ]);
         expect(exampleOperationWithOutput.dependencies).to.eql([
-          "tada-analytics.some_external_schema_name.very_important_external_table"
+          "some_database_name.some_external_schema_name.very_important_external_table"
         ]);
         expect(exampleOperationWithOutput.actionDescriptor).to.eql(
           dataform.ActionDescriptor.create({
@@ -424,12 +424,13 @@ describe("examples", () => {
 
         // Check declaration.
         const exampleDeclaration = graph.declarations.find(
-          d => d.name === "tada-analytics.some_external_schema_name.very_important_external_table"
+          d =>
+            d.name === "some_database_name.some_external_schema_name.very_important_external_table"
         );
         expect(exampleDeclaration).to.not.be.undefined;
         expect(exampleDeclaration.target).eql(
           dataform.Target.create({
-            database: "tada-analytics",
+            database: "some_database_name",
             schema: "some_external_schema_name",
             name: "very_important_external_table"
           })

version.bzl

@@ -1,3 +1,3 @@
 # NOTE: If you change the format of this line, you must change the bash command
 # in /scripts/publish to extract the version string correctly.
-DF_VERSION = "1.4.5"
+DF_VERSION = "1.4.6"