Define primaryKey and examples for model to follow the changes in datacontract-specification v1.1.0
#559
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syou6162
changed the title
primaryKey and examples for model
syou6162
force-pushed
the
fix/define_model_level_primaryKey_and_examples
branch
from
ef57157 to
ff6ec61
Compare
syou6162
changed the title
primaryKey and examples for modelprimaryKey and examples for model to follow the changes in v1.1.0
syou6162
changed the title
primaryKey and examples for model to follow the changes in v1.1.0primaryKey and examples for model to follow the changes in datacontract-specification v1.1.0
syou6162
commented
Dec 20, 2024
Merged
4 tasks
|
Once this pull request has been approved and merged, I will set #562 to ready for review. |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In datacontract-specification v1.1.0, the model-level
primaryKeyandexampleswere added to the fields.However, the addition of model-level
primaryKeyandexampleswas not reflected in the implementation of datacontract-cli, so we added it.This pull request is mainly for #562, but since defining
primaryKeyandexamplesis a topic that goes beyond dbt-style imports, I've split it out into this pull request.