-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit 202411 #23
Merged
Merged
Audit 202411 #23
+72
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
EELC2: improve validation of `Fraction` Signed-off-by: Jun Kimura <[email protected]>
bluele
commented
Dec 23, 2024
.github/workflows/test.yml
Outdated
@@ -22,6 +22,8 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@v4 | |||
- uses: actions-rust-lang/setup-rust-toolchain@v1 | |||
with: | |||
toolchain: 1.82.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: Fix for lint error
To upgrade to 1.83, we need to fix some lint warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed at 021ca43
Signed-off-by: Jun Kimura <[email protected]>
S-1: fix typo Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Fix lint error since rust 1.83 Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Improve url validation Signed-off-by: Jun Kimura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.