fix to validate fork parameters in DefaultChainContext::new()

Signed-off-by: Jun Kimura <[email protected]>
datachainlab · Oct 27, 2024 · 299eee1 · 299eee1
1 parent c77d6f4
commit 299eee1
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/crates/consensus/src/compute.rs b/crates/consensus/src/compute.rs
@@ -95,8 +95,9 @@ mod tests {
 
     #[test]
     fn test_compute_timestamp_at_slot() {
-        let ctx = DefaultChainContext::new_with_config(1729846322.into(), get_minimal_config());
-        assert!(ctx.validate().is_ok(), "context is invalid");
+        let res = DefaultChainContext::new_with_config(1729846322.into(), get_minimal_config());
+        assert!(res.is_ok(), "{:?}", res.err());
+        let ctx = res.unwrap();
         assert_eq!(compute_timestamp_at_slot(&ctx, 0.into()), 1729846322.into());
         assert_eq!(compute_timestamp_at_slot(&ctx, 1.into()), 1729846328.into());
         assert_eq!(compute_timestamp_at_slot(&ctx, 2.into()), 1729846334.into());

diff --git a/crates/consensus/src/context.rs b/crates/consensus/src/context.rs
@@ -29,17 +29,19 @@ impl DefaultChainContext {
         seconds_per_slot: U64,
         slots_per_epoch: Slot,
         epochs_per_sync_committee_period: Epoch,
-    ) -> Self {
-        Self {
+    ) -> Result<Self, Error> {
+        let this = Self {
             genesis_time,
             fork_parameters,
             seconds_per_slot,
             slots_per_epoch,
             epochs_per_sync_committee_period,
-        }
+        };
+        this.validate()?;
+        Ok(this)
     }
 
-    pub fn new_with_config(genesis_time: U64, config: Config) -> Self {
+    pub fn new_with_config(genesis_time: U64, config: Config) -> Result<Self, Error> {
         Self::new(
             genesis_time,
             config.fork_parameters,
@@ -49,7 +51,7 @@ impl DefaultChainContext {
         )
     }
 
-    pub fn validate(&self) -> Result<(), Error> {
+    fn validate(&self) -> Result<(), Error> {
         self.fork_parameters.validate()?;
         Ok(())
     }

diff --git a/crates/consensus/src/fork/bellatrix.rs b/crates/consensus/src/fork/bellatrix.rs
@@ -494,8 +494,9 @@ mod tests {
 
         // ensure that signing_root calculation is correct
 
-        let ctx = DefaultChainContext::new_with_config(0.into(), config::mainnet::get_config());
-        assert!(ctx.validate().is_ok(), "context is invalid");
+        let res = DefaultChainContext::new_with_config(0.into(), config::mainnet::get_config());
+        assert!(res.is_ok(), "{:?}", res.err());
+        let ctx = res.unwrap();
         let fork_version =
             compute_fork_version(&ctx, compute_epoch_at_slot(&ctx, update.signature_slot)).unwrap();
         let domain = compute_domain(