Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check txMaxSize. #53

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Check txMaxSize. #53

merged 3 commits into from
Sep 20, 2024

Conversation

dai1975
Copy link
Contributor

@dai1975 dai1975 commented Sep 20, 2024

The txMaxSize is statically written in geth source code.
Node runner or chain owner may modify this value.

So it should best that relayer can customize this value, but currently it is hard corded.

@dai1975 dai1975 requested a review from siburu September 20, 2024 06:27
@siburu
Copy link
Contributor

siburu commented Sep 20, 2024

@dai1975 Thank you very much, but could you make txMaxSize configurable via ChainConfig?

As I understand, the necessary steps are as follows.

  1. fix config.proto
  2. make proto-gen
  3. fix a logic that references txMaxSize

Signed-off-by: Daisuke Kanda <[email protected]>
@dai1975 dai1975 force-pushed the lo5087-check-maxsize branch from bb6588a to b10093a Compare September 20, 2024 07:16
Signed-off-by: Daisuke Kanda <[email protected]>
@dai1975 dai1975 force-pushed the lo5087-check-maxsize branch from 51aeb1e to e3a4d20 Compare September 20, 2024 07:23
@dai1975
Copy link
Contributor Author

dai1975 commented Sep 20, 2024

make txMaxSize configurable.

  • optional config. if null or 0, set to 128KB.
  • if 1 tx exceeds txMaxSize, ignore the limit.
  • add log to tx.Size

@siburu siburu merged commit 59edbc5 into datachainlab:main Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants