log rawTx when fail to send tx #51
Merged
+70
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
dai1975
force-pushed
the
features/lo4500-log-tx
branch
from
e6e7108 to
21ec2bc
Compare
dai1975
commented
Jul 26, 2024
| @@ -2,7 +2,7 @@ package ethereum | |||
|
|
|||
| const ( | |||
| logAttrMsgIndexFrom = "msg_index_from" | |||
| logAttrMsgIndexTo = "msg_index_to" | |||
There was a problem hiding this comment.
change info for readers to avoid from confusing to is inclusive or not.
dai1975
commented
Jul 26, 2024
| @@ -406,7 +413,7 @@ func (c *Chain) getRevertReasonFromReceipt(ctx context.Context, receipt *client. | |||
|
|
|||
| func (c *Chain) getRevertReasonFromRpcError(err error) (string, []byte, error) { | |||
| if de, ok := err.(rpc.DataError); !ok { | |||
| return "", nil, fmt.Errorf("failed with unexpected error type: errorType=%T", err) | |||
There was a problem hiding this comment.
output normal log in case of failing to rpc call itself.
dai1975
commented
Jul 26, 2024
| iter.cursor = min(len(iter.msgs), iter.cursor + n) | ||
| } | ||
|
|
||
| func (iter *CallIter) updateLoggerMessageInfo(logger *log.RelayLogger, from int, count int) { |
There was a problem hiding this comment.
Being buildTx more common function, caller of buildTx need to add info of msgs in using buildTx to logger.
This is helper function for it.
Signed-off-by: Daisuke Kanda <[email protected]>
dai1975
force-pushed
the
features/lo4500-log-tx
branch
from
5eefac0 to
b1c9fd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log rawTx when fail to send tx