multicall

[dai1975]

Send tx by using Multicall3

[siburu]

@dai1975 I reviewed codes except for relay/ethereum/tx.go and put some comments.
I will review tx.go from now.

[siburu]

@dai1975 Sorry for late reply! I put some comments.

[dai1975]

rebase.

[siburu]

@dai1975 I'm sorry for late review.
I left some comments.

[siburu]

After fixing estimateGas as I pointed out, the use of new block (L537 and L553) and the shadowing of logger can be omitted.

[dai1975]

fixed

[siburu]

• The return value of Next() is not used at all.
• The last return statement should be fixed as follows, right?
  • return iter.End()

[dai1975]

return value of Next means not that the cursor is end after Next call, but that the Next is procceeded or not(like return error).
But it is confusing and no one uses the returned value, I've simply drop return value.

[siburu]

Is msg_index_to inclusive or exclusive?

[dai1975]

The meaning of to is differ in logging context.
But it is not good.
Fix that all "to" means inclusive index.

[siburu]

Why does this code only log the type of the last msg?

[dai1975]

modify to output all message types.

[dai1975]

and add log in case of multicall.Aggregate succeeded.

[siburu]

I think the second argument of findItems and the second argument of fnTest can be omitted, because fnTest is basically defined as a lambda and the lambda can directly access data.

[dai1975]

fixed

[siburu]

Suggested change

	func findItems[D any](
	size int,
	userdata *D,
	fnTest func(int, *D) (error),
	) (int, error) {
	if (size <= 0) {
	return 0, fmt.Errorf("empty items")
	}
	lastOkCount := 0
	lastNgCount := 0
	for true {
	var count int
	if lastNgCount == 0 {
	count = size
	if lastOkCount == count {
	return lastOkCount, nil
	}
	} else if lastOkCount == 0 {
	if lastNgCount == 1 {
	return 0, fmt.Errorf("not found")
	}
	count = lastNgCount / 2 // note that lastNgCount >= 2
	} else if lastOkCount + 1 == lastNgCount {
	return lastOkCount, nil
	} else {
	count = (lastNgCount + lastOkCount) / 2
	}
	err := fnTest(count, userdata)
	if err != nil {
	if count == 1 {
	return 0, err
	}
	lastNgCount = count
	} else {
	lastOkCount = count
	}
	}
	return lastOkCount, nil // not reached
	}
	func findItems(size uint, f func(uint) error) (uint, error) {
	if size <= 0 {
	return 0, fmt.Errorf("empty items")
	}
	// hot path
	if err := f(size); err == nil {
	return size, nil
	}
	// binary search
	if i := sort.Search(size-1, func(n int) bool { return f(n+1) != nil }); i == 0 {
	return 0, fmt.Errorf("not found")
	} else {
	return i, nil
	}
	}

[dai1975]

I've not know sort.Search and replaced codes with yours.

[siburu]

@dai1975 sdk.Msg is not struct but interface.
We need not use a pointer to the interface here.

[dai1975]

fixed

[siburu]

@dai1975 LGTM. Thank you!!