Improve logging at SendMsgs and GetMsgResult #44
Merged
+103
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masanori Yoshida <[email protected]>
siburu
force-pushed
the
improve-sendmsgs-logging
branch
from
b967b70 to
5152347
Compare
bluele
reviewed
May 23, 2024
pkg/relay/ethereum/tx.go
Outdated
| if err2 != nil { | ||
| logger.Error("failed to get revert reason", err2, "msg_index", i) | ||
| var revertReason, rawErrorData string | ||
| if reason, data, err := c.getRevertReasonFromEstimateGas(err); err != nil { |
There was a problem hiding this comment.
@siburu We should include raw error data in the log even if the `ErrorRepository's parser function returns an error.
…able Signed-off-by: Masanori Yoshida <[email protected]>
bluele
reviewed
May 23, 2024
pkg/relay/ethereum/tx.go
Outdated
| txGasLimit = c.Config().MaxGasLimit | ||
| } | ||
| opts.GasLimit = txGasLimit | ||
| opts.NoSend = false | ||
| tx, err = c.SendTx(opts, msg, skipUpdateClientCommitment) | ||
| if bz, err := tx.MarshalBinary(); err != nil { |
There was a problem hiding this comment.
@siburu If the tx is nil(and err !=nil) at line 96, doest it cause a nil reference error?
Signed-off-by: Masanori Yoshida <[email protected]>
Signed-off-by: Masanori Yoshida <[email protected]>
Signed-off-by: Masanori Yoshida <[email protected]>
Signed-off-by: Masanori Yoshida <[email protected]>
mizuochik
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.