Support for logging custom errors on tx execution revert in not only real tx execution but also gas estimation #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dongri Jin <[email protected]> Add defaultError Signed-off-by: Dongri Jin <[email protected]> Add test case Signed-off-by: Dongri Jin <[email protected]> Add panic error Signed-off-by: Dongri Jin <[email protected]> Add abi_paths Signed-off-by: Dongri Jin <[email protected]> Fix parse abi files Signed-off-by: Dongri Jin <[email protected]> * Move package Signed-off-by: Dongri Jin <[email protected]> Add GetRevertReason to after DebugTraceTransaction Signed-off-by: Dongri Jin <[email protected]> * Fix erepo create * Fix add error repo Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Masanori Yoshida <[email protected]>
siburu
changed the title
Signed-off-by: Masanori Yoshida <[email protected]>
This was referenced Apr 24, 2024
bluele
reviewed
Apr 24, 2024
bluele
reviewed
Apr 24, 2024
bluele
reviewed
Apr 24, 2024
Signed-off-by: Masanori Yoshida <[email protected]>
Signed-off-by: Masanori Yoshida <[email protected]>
bluele
reviewed
Apr 24, 2024
Signed-off-by: Masanori Yoshida <[email protected]>
bluele
reviewed
Apr 24, 2024
Signed-off-by: Masanori Yoshida <[email protected]>
bluele
reviewed
Apr 24, 2024
bluele
reviewed
Apr 24, 2024
siburu
force-pushed
the
custom-error
branch
5 times, most recently
from
f057d35 to
9a63ad9
Compare
…if the corresponding error ABI is unknown Signed-off-by: Masanori Yoshida <[email protected]>
Signed-off-by: Masanori Yoshida <[email protected]>
bluele
approved these changes
Apr 25, 2024
Signed-off-by: Masanori Yoshida <[email protected]>
…ndMsgs` Signed-off-by: Masanori Yoshida <[email protected]>
bluele
reviewed
Apr 26, 2024
pkg/relay/ethereum/tx.go
Outdated
| @@ -113,7 +114,7 @@ func (c *Chain) GetMsgResult(id core.MsgID) (core.MsgResult, error) { | |||
| if receipt.Status == gethtypes.ReceiptStatusSuccessful { | |||
| return c.makeMsgResultFromReceipt(&receipt.Receipt, "") | |||
| } | |||
| revertReason, err := c.getRevertReasonFromReceipt(ctx, receipt) | |||
| revertReason, _, err := c.getRevertReasonFromReceipt(ctx, receipt) | |||
| if err != nil { | |||
| logger.Error("failed to get revert reason", err) | |||
There was a problem hiding this comment.
Should we also contain errorData in the error log?
There was a problem hiding this comment.
🤔 ... sure. I will fix it.
There was a problem hiding this comment.
ah ... should we also add tx_hash here?
Signed-off-by: Masanori Yoshida <[email protected]>
Signed-off-by: Masanori Yoshida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.