Filter channel id #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dongri Jin <[email protected]>
siburu
reviewed
Mar 19, 2024
pkg/relay/ethereum/events.go
Outdated
| @@ -160,6 +163,9 @@ func (chain *Chain) findRecvPacketEvents(ctx core.QueryContext, fromHeight uint6 | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to parse RecvPacket event: err=%v, log=%v", err, log) | |||
| } | |||
| if event.Packet.SourceChannel != chain.Path().ChannelID { | |||
There was a problem hiding this comment.
In findWriteAckEvents you chose DestinationChannel, but you chose SourceChannel here. Why?
There was a problem hiding this comment.
Fix to DestinationChannel
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ethereum chain module's event query is modified to return only events from a specific channel