Skip to content

Commit

Permalink
fix to use GetIBCModuleByChannel instead of GetIBCModuleByPort
Browse files Browse the repository at this point in the history
Signed-off-by: Jun Kimura <[email protected]>
  • Loading branch information
bluele committed Sep 30, 2024
1 parent d46813f commit 54afcbc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions pkg/relay/ethereum/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ func proposeAppVersionCmd(ctx *config.Context) *cobra.Command {
return ethChain.ProposeAppVersion(
cmd.Context(),
ethChain.pathEnd.PortID,
ethChain.pathEnd.ChannelID,
version,
implementation,
initialCalldata,
Expand Down
4 changes: 3 additions & 1 deletion pkg/relay/ethereum/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,19 +103,21 @@ func (c *Chain) AllowTransitionToFlushComplete(
func (c *Chain) ProposeAppVersion(
ctx context.Context,
portID string,
channelID string,
version string,
implementation common.Address,
initialCalldata []byte,
) error {
logger := c.GetChainLogger()
logger = &log.RelayLogger{Logger: logger.With(
logAttrPortID, portID,
logAttrChannelID, channelID,
logAttrVersion, version,
logAttrImplementation, implementation.Hex(),
logAttrInitialCalldata, hex.EncodeToString(initialCalldata),
)}

appAddr, err := c.ibcHandler.GetIBCModuleByPort(c.CallOpts(ctx, 0), portID)
appAddr, err := c.ibcHandler.GetIBCModuleByChannel(c.CallOpts(ctx, 0), portID, channelID)
if err != nil {
return err
}
Expand Down

0 comments on commit 54afcbc

Please sign in to comment.