explicitly set data security mode to SINGLE_USER #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpitjasa-db
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Thanks @shichengzhou-db ! Would you mind also fixing the tests that are failing?
| @@ -3,6 +3,7 @@ new_cluster: &new_cluster | |||
| num_workers: 3 | |||
| spark_version: 15.3.x-cpu-ml-scala2.12 | |||
| node_type_id: {{template `cloud_specific_node_type_id` .}} | |||
| data_security_mode: "SINGLE_USER" | |||
There was a problem hiding this comment.
Can we confirm these workflows still run on AWS, Azure, and GCP?
There was a problem hiding this comment.
confirmed this works on dogfood(aws), will test the other in a bit
shichengzhou-db
force-pushed
the
cluster_data_security_mode
branch
2 times, most recently
from
3badd2a
to
9b6faa2
Compare
shichengzhou-db
force-pushed
the
cluster_data_security_mode
branch
from
9b6faa2
to
037b706
Compare
@arpitjasa-db (Will test the other workflows on all clouds as well tmmrw and document in the PR description) |
arpitjasa-db
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.
Manual tested all workflows on all clouds (aws/azure/gcp), no failures related to data_security_mode. Although the workflows seems to be broken for various issues that need to be looked into separately.