Refactor: respond to client even when leader is switched #973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Refactor: respond to client even when leader is switched
Before this commit, the channels used for sending responses to the
client were dropped whenever a leader stepped down, which was not
necessary.
In the current commit, when a leader quits, we now preserve the channel, ensuring that:
An OK response is sent to the client if the log entry the client has
written is successfully committed;
Alternatively, a
ForwardToLeader
error is sent if the log isreverted due to a conflict with the new leader.
In short, OpenRaft now makes a concerted effort to deliver a success
message to the client wherever possible.
Two test cases have been added to cover both successful and erroneous
scenarios.
Special thanks to @tvsfx for proposing this refinement :D
client_resp_channels
fromLeaderData
to newtx_...
-field inRaftCore
#963This change is