Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add new methods to openraft::metrics::Wait #960

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Dec 7, 2023

Changelog

Feature: Add new methods to openraft::metrics::Wait

Add log_index(), log_index_at_least(), applied_index() and
applied_index_at_least() to openraft::metrics::Wait to replace
Wait::log() and Wait::log_at_least().

These two methods are deprecated since 0.9.0 because the names does
not imply that they will be blocked by last_applied log index.

Thanks to @tvsfx


This change is Reviewable

Add `log_index()`, `log_index_at_least()`, `applied_index()` and
`applied_index_at_least()` to `openraft::metrics::Wait` to replace
`Wait::log()` and `Wait::log_at_least()`.

These two methods are deprecated since `0.9.0` because the names does
not imply that they will be blocked by `last_applied` log index.

Thanks to @tvsfx
@drmingdrmer
Copy link
Member Author

@tvsfx
I hope this PR clears up any existing confusion. :)

@drmingdrmer drmingdrmer merged commit 10c7337 into databendlabs:main Dec 7, 2023
25 checks passed
@drmingdrmer drmingdrmer deleted the 47-metrics-wait branch December 7, 2023 09:20
@drmingdrmer drmingdrmer mentioned this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant