Refactor: fix handling of non-voter leader #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Openraft does not require Leader/Candidate to be a voter. Before this commit, Openraft's handling of non-voter leader is inconsistent: For a node that has a vote proposed by this node and is committed, and is not a voter: - [`calc_server_state()`](https://github.com/datafuselabs/openraft/blob/97254a31c673e52429ee7187de96fd2ea2a5ce98/openraft/src/raft_state/mod.rs#L323) returns `Learner`. - But [`is_leader()`](https://github.com/datafuselabs/openraft/blob/97254a31c673e52429ee7187de96fd2ea2a5ce98/openraft/src/raft_state/mod.rs#L353) returns true. Since this commit, `calc_server_state()` and `is_leader()` returns consistent result according to the following table: For node-2: - Node-2 with vote `(term=1, node_id=2, committed=true)`: - is a leader if it is **present** in config, either a voter or non-voter. - is a learner if it is **absent** in config. - Node-2 with vote `(term=1, node_id=2, committed=false)`: - is a candidate if it is **present** in config, either a voter or non-voter. - is a learner if it is **absent** in config. - Node-3 with vote `(term=1, node_id=99, committed=false|true)`: - is a follower if it is a **voter** in config, - is a learner if it is a **non-voter** or **absent** in config. | vote \ membership | Voter | Non-voter | Absent | |---------------------------------------|-----------|-----------|---------| | (term=1, node_id=2, committed=true) | leader | leader | learner | | (term=1, node_id=2, committed=false) | candidate | candidate | learner | | (term=1, node_id=99, committed=true) | follower | learner | learner | | (term=1, node_id=99, committed=false) | follower | learner | learner | - Fix: databendlabs#920
drmingdrmer
force-pushed
the
44-fix-920
branch
from
5460892 to
f4564fe
Compare
…ase 'add_learner_non_blocking'. In this case, a replication failure status is supposed to be reported to the matrix. But sometimes it times out before the failure report can be delivered. To address this issue, just extend the time out duration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Refactor: fix handling of non-voter leader
Openraft does not require Leader/Candidate to be a voter.
Before this commit, Openraft's handling of non-voter leader is
inconsistent:
For a node that has a vote proposed by this node and is committed, and is not a voter:
calc_server_state()returnsLearner.is_leader()returns true.Since this commit,
calc_server_state()andis_leader()returns consistent result according to the following table:For node-2:
Node-2 with vote
(term=1, node_id=2, committed=true):Node-2 with vote
(term=1, node_id=2, committed=false):Node-3 with vote
(term=1, node_id=99, committed=false|true):This change is