oracle adapter support #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Oracle adapter support
stumelius
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Thank you for opening this PR @vinodsugur, and sorry for the delay in getting to review this. Oracle support would definitely be a nice-to-have feature. The code in general looks good and I left a few comments. Can you address those? Can you also make sure that Oracle gets added to the supported adapters list in the README?
I have resolved open queries.
vinodsugur
commented
Nov 27, 2024
|
|
I have closed on all open points. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Oracle adapter support
Description & motivation
Checklist
integration_tests/models, dbt data tests inintegration_tests/testsor integration tests in the CI workflow)