Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2737 street view gps #2748

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

2737 street view gps #2748

wants to merge 9 commits into from

Conversation

atalyaalon
Copy link
Collaborator

@atalyaalon atalyaalon commented Dec 28, 2024

Since street_view widget uses newsflash data, it needs to be updated after cache - note that during cache calculation the is_included function is False.
Therefore two changes where made: I added update_result to street_view, and changed the order in infographics_utils.py such that first updating output using update_cache_results occurs and only later empty widgets are filtered out

@atalyaalon atalyaalon requested a review from ziv17 December 28, 2024 14:31
@atalyaalon atalyaalon linked an issue Dec 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Modify Street View Widget GPS to be newsflash GPS
1 participant