Coerce timestamp units in metadata #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IzerOnadimQC
requested review from
jtilly,
DamianB-BitFlipper,
DamianBarabonkovQC,
xhochy and
fjetter
as code owners
jtilly
approved these changes
Oct 31, 2023
IzerOnadimQC
merged commit 2e2740e
into
data-engineering-collective:main
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
plateauonly supports timestamps with nanosecond resolution.When saving to parquet files, all timestamp units are coerced (by arrow) to microsecond resolution, and then coerced back (by
plateau) to nanoseconds after being loaded. This PR ensures that the conversion process does not cause an error by similarly coercing the units of timestamps in table schemas.This PR also prepares the release of
plateau4.2.1.