Port to pixi and QuantCo Oss copier template #153
Conversation
|
@xhochy For now, I kept python 3.8. Or should we use this PR to remove support for 3.8 since it has already reached end of life:(https://devguide.python.org/versions/). |
|
Please drop 3.8, we don't want to keep it as baggage. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 0.00% 85.38% +85.38%
==========================================
Files 32 32
Lines 2001 2012 +11
==========================================
+ Hits 0 1718 +1718
+ Misses 2001 294 -1707 ☔ View full report in Codecov by Sentry. |
thomasmarwitz
requested review from
siboehm,
mlondschien,
xhochy and
fjetter
as code owners
|
Regarding version bump: Is this minor or patch? |
| name: artifact | ||
| path: dist/* | ||
|
|
||
| release: |
There was a problem hiding this comment.
I have no way of testing this (the release workflow) but it basically just the copier template code
| user: __token__ | ||
| password: ${{ secrets.pypi_password }} |
There was a problem hiding this comment.
Except the authentication I added based on the previous ci.yml workflow
There was a problem hiding this comment.
We should change this to OIDC instead of using a password.
I can do the testing once we have merge.
|
Lots of files were reformatted due to more pre-commit hooks. Also pyupgrade yielded some changes |
|
Is this ready for a review? |
|
thomasmarwitz
force-pushed
the
add-pixi
branch
from
384fabf to
01b84aa
Compare
Otherwise, headings are confused with merge conflict.
Whitespace at eof, ruff pyupgrade, typos, formatting.
thomasmarwitz
force-pushed
the
add-pixi
branch
from
6d95d72 to
bc7b8b5
Compare
|
@xhochy I added a changelog where I incremented the patch version. |
thomasmarwitz
changed the title
Co-authored-by: Uwe L. Korn <[email protected]>
Checklist
docs/changes.rstentry