Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow session_token to be set for S3 buckets. Truly isolates stores by explicitly setting credentials for S3FS. #114

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Allow session_token to be set for S3 buckets. Truly isolates stores by explicitly setting credentials for S3FS. #114

merged 4 commits into from
Feb 27, 2024

Conversation

ThomasMarwitzQC
Copy link
Collaborator

@ThomasMarwitzQC ThomasMarwitzQC commented Feb 16, 2024 •
edited
Loading

  • Allow to specify a session_token url param to support

@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (f2a7c01) to head (25806b2).
Report is 4 commits behind head on main.

Files Patch % Lines
minimalkv/net/s3fsstore.py 0.00% 16 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main    #114   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         32      32           
  Lines       1989    2001   +12     
=====================================
- Misses      1989    2001   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasMarwitzQC ThomasMarwitzQC force-pushed the add-session-support-s3 branch 3 times, most recently from 2255e7b to ea21f60 Compare February 23, 2024 14:12
@ThomasMarwitzQC ThomasMarwitzQC marked this pull request as ready for review February 23, 2024 14:24
fhoehle
fhoehle approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@fhoehle fhoehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @xhochy

@xhochy
Copy link
Member

xhochy commented Feb 27, 2024 •
edited
Loading

Can you please add an entry to https://github.com/data-engineering-collective/minimalkv/blob/main/docs/changes.rst ?

xhochy
xhochy reviewed Feb 27, 2024
View reviewed changes
docs/changes.rst Outdated Show resolved Hide resolved
@xhochy xhochy merged commit 077305c into data-engineering-collective:main Feb 27, 2024
12 checks passed
@ThomasMarwitzQC ThomasMarwitzQC deleted the add-session-support-s3 branch February 27, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy approved these changes

@fhoehle fhoehle fhoehle approved these changes

@siboehm siboehm Awaiting requested review from siboehm siboehm is a code owner

@mlondschien mlondschien Awaiting requested review from mlondschien mlondschien is a code owner

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasMarwitzQC @xhochy @fhoehle