Get rid of some TODOs/FIXMEs.

data-engineering-collective · Apr 27, 2021 · 8f3eb7f · 8f3eb7f
1 parent 799ed45
commit 8f3eb7f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/minimalkv/__init__.py b/minimalkv/__init__.py
@@ -195,7 +195,7 @@ def put_file(self, key: str, file: Union[str, File]) -> str:
         :raises ValueError: If the key is not valid.
         :raises IOError: If there was a problem moving the file in.
         """
-        # FIXME: shouldn't we call self._check_valid_key here?
+        self._check_valid_key(key)
         if isinstance(file, str):
             return self._put_filename(key, file)
         else:
@@ -432,10 +432,6 @@ def put_file(
         :raises IOError: If there was a problem moving the file in.
         :raises ValueError: If ``ttl_secs`` is invalid.
         """
-        # TODO: Remove next two lines?
-        if ttl_secs is None:
-            ttl_secs = self.default_ttl_secs
-
         self._check_valid_key(key)
 
         if isinstance(file, str):

diff --git a/minimalkv/contrib/__init__.py b/minimalkv/contrib/__init__.py
@@ -28,7 +28,6 @@ def _check_valid_key(self, key: Optional[str]) -> None:
 
         :param key: The key to be checked
         """
-        # TODO: Is there any case where key is None?
         if key is not None:
             if not isinstance(key, str):
                 raise ValueError("%r is not a valid key type" % key)