Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test_get_dashboard_unauthorized #1736

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix test_get_dashboard_unauthorized #1736

merged 1 commit into from
Dec 9, 2024

Conversation

petrkalos
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

Before #1729 an unauthorized getDashboard query meant a global failure, after #1729 it returns partial data and only raises an error for environment and restricted fields.

{'data': {'getDashboard': {'SamlGroupName': 'testGroup1',
                           'created': '2024-12-06 15:27:15.811303',
                           'dashboardUri': 'obfuscated_uri',
                           'description': 'No description provided',
                           'environment': None,
                           'label': '2024-12-06T14:57:28.249142',
                           'name': '2024-12-06t14-57-28-249142',
                           'owner': '[email protected]',
                           'restricted': None,
                           'tags': ['2024-12-06T14:57:28.249142'],
                           'terms': {'count': 0, 'nodes': []},
                           'userRoleForDashboard': 'Shared'}},
 'errors': [{'locations': [{'column': 17, 'line': 13}],
             'message': '\n'
                        '            An error occurred (UnauthorizedOperation) '
                        'when calling GET_DASHBOARD operation:\n'
                        '            User: [email protected] is not '
                        'authorized to perform: GET_DASHBOARD on resource: '
                        'obfuscated_uri\n'
                        '        ',
             'path': ['getDashboard', 'restricted']},
            {'locations': [{'column': 17, 'line': 17}],
             'message': '\n'
                        '            An error occurred (UnauthorizedOperation) '
                        'when calling GET_ENVIRONMENT operation:\n'
                        '            User: [email protected] is not '
                        'authorized to perform: GET_ENVIRONMENT on resource: '
                        'obfuscated_uri\n'
                        '        ',
             'path': ['getDashboard', 'environment']}]}

Relates

Issue introduced at #1729

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@dlpzx dlpzx merged commit bd25484 into main Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants