Add LIST_ENVIRONMENT_DATASETS permission for listing shared datasets and cleanup unused code #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpzx
requested review from
noah-paige and
SofiaSazonova
and removed request for
noah-paige
SofiaSazonova
approved these changes
Nov 22, 2024
| context = get_context() | ||
| if group_uri not in context.groups: |
There was a problem hiding this comment.
This condition (or the similar ones) is widely used.
May be we can make a decorator out of it?
noah-paige
reviewed
Nov 22, 2024
Comment on lines
-70
to
-76
| @staticmethod | ||
| @ResourcePolicyService.has_resource_permission(GET_DATASET) | ||
| @is_feature_enabled('modules.s3_datasets.features.metrics_data') | ||
| def list_profiling_runs(uri): | ||
| with get_context().db_engine.scoped_session() as session: | ||
| return DatasetProfilingRepository.list_profiling_runs(session, uri) | ||
|
|
There was a problem hiding this comment.
if removing here - should we not remove def list_profiling_runs(session, dataset_uri) from dataall/backend/dataall/modules/s3_datasets/db/dataset_profiling_repositories.py ?
Comment on lines
42
to
46
| @staticmethod | ||
| def get_table(uri: str): | ||
| with get_context().db_engine.scoped_session() as session: | ||
| return DatasetTableRepository.get_dataset_table_by_uri(session, uri) | ||
|
|
There was a problem hiding this comment.
Reverted, not sure why this was modified
| if group_uri not in context.groups: | ||
| raise exceptions.UnauthorizedOperation( | ||
| action='LIST_ENVIRONMENT_GROUP_DATASETS', | ||
| message=f'User: {context.username} is not a member of the team {group_uri}', |
There was a problem hiding this comment.
nit: this is 1 example where we may not want to use input in output error message in the case of bad inputs being used to reflect back
This reverts commit 6c01162.
petrkalos
approved these changes
Nov 28, 2024
dlpzx
added a commit
that referenced
this pull request
Dec 5, 2024
…and cleanup unused code (#1719) - Bugfix Added permission check on the list datasets API calls from the S3 shares module. Ensuring that only environment members can see environment shared datasets. ++ remove some unused code Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Added permission check on the list datasets API calls from the S3 shares module. Ensuring that only environment members can see environment shared datasets.
++ remove some unused code
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.