Added permission check - is tenant to update SSM parameters API #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noah-paige
reviewed
Nov 22, 2024
| @@ -121,6 +123,26 @@ def validate_permissions(session, tenant_name, g_permissions, group): | |||
| return tenant_group_permissions | |||
|
|
|||
|
|
|||
| class TenantActionsService: | |||
| @staticmethod | |||
| def update_monitoring_ssm_parameter(name, value): | |||
There was a problem hiding this comment.
are we keeping this API or removing this along with other Admin Dashboard ones?
There was a problem hiding this comment.
I see what you did in https://github.com/data-dot-all/dataall/pull/1712/files
noah-paige
reviewed
Nov 22, 2024
Comment on lines
+137
to
+142
| response = ParameterStoreManager.update_parameter( | ||
| AwsAccountId=current_account, | ||
| region=region, | ||
| parameter_name=f'/dataall/{os.getenv("envname", "local")}/quicksightmonitoring/{name}', | ||
| parameter_value=value, | ||
| ) |
There was a problem hiding this comment.
I know this is carry over from resolver code - but this does not work...
All of the following use ParameterStore and try to assume into pivotRole in infra account to get SSM (pivot role DNE in infra account)
createQuicksightDataSourceSet,
getMonitoringDashboardId,
getMonitoringVPCConnectionId,
updateSSMParameter
Will approve this PR but leave this comment in https://github.com/data-dot-all/dataall/pull/1712/files where I think more focus is on QuickSight Monitoring View
noah-paige
approved these changes
Nov 22, 2024
SofiaSazonova
approved these changes
Nov 22, 2024
dlpzx
added a commit
that referenced
this pull request
Dec 5, 2024
### Feature or Bugfix - Feature ### Detail - Added service function and check if the user is a tenant for the updateSSM API call ### Relates - <URL or Ticket> ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.