CICD Integration tests: new shares for pre-existing datasets #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 4, 2024 11:52
petrkalos
requested changes
Oct 7, 2024
Comment on lines
204
to
206
| if list_organizations(client6).count == 0: | ||
| invite_team_to_organization(client5, persistent_cross_acc_env_1.organization.organizationUri, group6) | ||
| if list_environments(client6).count == 0: |
There was a problem hiding this comment.
if org/env have non-zero count because of some other change (i.e a manual change or some other test changing it) group6 will end up not invited.
I think it would be better if you invite_to_org/invite_to_env and then catch the errors if any (i.e already part of the env/group)
There was a problem hiding this comment.
I added an explicit check by uri
|
|
||
|
|
||
| @pytest.fixture(scope='session') | ||
| def session_consumption_role_2( |
There was a problem hiding this comment.
perhaps create a contextmanager and reuse it for all consumption_roles?
added 5 commits
October 9, 2024 10:50
petrkalos
approved these changes
Nov 29, 2024
dlpzx
reviewed
Dec 10, 2024
| return group_workgroup | ||
| elif env_workgroup: | ||
| return env_workgroup | ||
| return default_workgroup |
There was a problem hiding this comment.
If here we are returning the workgroup for groups (not for consumption roles) we should throw an error instead of returning the primary if no group_workgroup or env_workgroup is found
SofiaSazonova
commented
Dec 20, 2024
| @@ -697,7 +697,7 @@ def create_integration_tests_role(self): | |||
| ], | |||
| effect=iam.Effect.ALLOW, | |||
| resources=[ | |||
| f'arn:aws:iam::{self.account}:role/dataall-test-*', | |||
| f'arn:aws:iam::{self.account}:role/dataall-test*', | |||
There was a problem hiding this comment.
This was made, so the int test role could ListPolicies for role dataall-testgroup-*
dlpzx
pushed a commit
that referenced
this pull request
Dec 26, 2024
<!-- please choose --> - Feature For group share and consumption role shares perform - [x] Create Share request - [x] Submit request without Items (not allowed) - [x] Add items to request - [x] Submit request - [x] Change request purpose - [x] Reject request - [x] Change reject purpose - [x] Approve request - [x] Request succeeded - [x] Item health verification - [x] Folder sharing validation (cal list objects via s3 accesspoint) - [x] Bucket sharing validation (cal list objects in s3 bucket ) - [x] Table sharing validation (cal perform athena query: select * from db.table ) - [x] Revoke items - [x] Folder sharing validation (no more access) - [x] Bucket sharing validation (no more access) - [x] Table sharing validation (no more access) - [x] Delete share Tests are the same as for new shares for new datasets Fixtures are parametrised - #1376 Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Sofia Sazonova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
For group share and consumption role shares perform
Tests are the same as for new shares for new datasets
Fixtures are parametrised
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.