Implement printUnauthorized utility for FE

data-dot-all · Dec 5, 2024 · c192c89 · c192c89
1 parent 4b675f3
commit c192c89
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/frontend/src/modules/S3_Datasets/components/DatasetFolders.js b/frontend/src/modules/S3_Datasets/components/DatasetFolders.js
@@ -37,6 +37,7 @@ import {
 } from 'design';
 import { SET_ERROR, useDispatch } from 'globalErrors';
 import { deleteDatasetStorageLocation, useClient } from 'services';
+import { emptyPrintUnauthorized } from 'utils';
 
 import { listDatasetStorageLocations } from '../services';
 import { FolderCreateModal } from './FolderCreateModal';
@@ -224,10 +225,9 @@ export const DatasetFolders = (props) => {
                           </Link>
                         </TableCell>
                         <TableCell>
-                          {`s3://${
-                            folder.restricted?.S3BucketName ||
-                            'UNAUTHORIZED_INFO'
-                          }/${folder.S3Prefix}`}
+                          {`s3://${emptyPrintUnauthorized(
+                            folder.restricted?.S3BucketName
+                          )}/${folder.S3Prefix}`}
                         </TableCell>
                         <TableCell>{folder.description}</TableCell>
                         <TableCell>

diff --git a/frontend/src/modules/S3_Datasets/components/DatasetTables.js b/frontend/src/modules/S3_Datasets/components/DatasetTables.js
@@ -40,7 +40,7 @@ import { listDatasetTables, deleteDatasetTable, useClient } from 'services';
 import { syncTables } from '../services';
 
 import { DatasetStartCrawlerModal } from './DatasetStartCrawlerModal';
-import { isFeatureEnabled } from 'utils';
+import { emptyPrintUnauthorized, isFeatureEnabled } from 'utils';
 
 export const DatasetTables = (props) => {
   const { dataset, isAdmin } = props;
@@ -261,11 +261,12 @@ export const DatasetTables = (props) => {
                           </Link>
                         </TableCell>
                         <TableCell>
-                          {table.restricted?.GlueDatabaseName ||
-                            'UNAUTHORIZED_INFO'}
+                          {emptyPrintUnauthorized(
+                            table.restricted?.GlueDatabaseName
+                          )}
                         </TableCell>
                         <TableCell>
-                          {table.restricted?.S3Prefix || 'UNAUTHORIZED_INFO'}
+                          {emptyPrintUnauthorized(table.restricted?.S3Prefix)}
                         </TableCell>
                         <TableCell>
                           {isAdmin && (

diff --git a/frontend/src/utils/helpers/emptyPrintUnauthorized.js b/frontend/src/utils/helpers/emptyPrintUnauthorized.js
@@ -0,0 +1,5 @@
+function emptyPrintUnauthorized(param) {
+  return param ? param : 'UNAUTHORIZED_INFO';
+}
+
+export { emptyPrintUnauthorized };
diff --git a/frontend/src/utils/helpers/index.js b/frontend/src/utils/helpers/index.js
@@ -1,5 +1,6 @@
 export * from './bytesToSize';
 export * from './dayjs';
+export * from './emptyPrintUnauthorized';
 export * from './listToTree';
 export * from './moduleUtils';
 export * from './linkMarkup';