Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: fix CI test errors #366

Merged
merged 8 commits into from
May 14, 2024
Merged

Maintenance: fix CI test errors #366

merged 8 commits into from
May 14, 2024

Conversation

GenevieveBuckley
Copy link
Collaborator

Code maintenance, fixing some errors that have popped up in the CI test suite. Mostly adjustments for code deprecation, and minor API changes in other libraries.

@m-albert
Copy link
Collaborator

Great, this unblocks a lot 🎉

The remaining error in the github CI seems to be related to #363 and probably gone once #363 is merged to master and rebased / merged here.

@GenevieveBuckley GenevieveBuckley deleted the fix-test-errors branch May 14, 2024 07:42
@GenevieveBuckley GenevieveBuckley restored the fix-test-errors branch May 14, 2024 07:43
@GenevieveBuckley
Copy link
Collaborator Author

Ok, all the CI checks are passing now, except the GPU python 3.9 job (but the GPU python 3.10 job does pass).
I think we'll make a separate issue for the GPU CI, and merge this PR now so we can unblock the other PRs we have.

@GenevieveBuckley GenevieveBuckley merged commit 54a3925 into main May 14, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants