-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml package setup #306
Conversation
I've noticed that Perhaps most critically in
(replacement might be and
underlying the gpuci failure (replacement might be |
Yeah in terms of CI changes with |
Co-authored-by: jakirkham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Genevieve! 🙏
Think this is coming along nicely 😄
Tried to help answer some questions and suggest some small changes on some of the trickier pieces
pyproject.toml
Outdated
markers = "cupy" | ||
|
||
[tool.flake8] | ||
exclude = "docs/conf.py,versioneer.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether to keep versioneer.py
here depends on the versioning decision above ( #306 (comment) )
Co-authored-by: jakirkham <[email protected]>
Co-authored-by: jakirkham <[email protected]>
Co-authored-by: jakirkham <[email protected]>
Co-authored-by: jakirkham <[email protected]>
Co-authored-by: jakirkham <[email protected]>
I merged main to start testing this branch |
The gpuCI fails with the following errpr:
Could it be that "setup.py" is mentioned somewhere in the Jenkins configuration? |
From CI:
Looks like this code needs an update: dask-image/continuous_integration/gpuci/build.sh Lines 46 to 47 in b23b615
Edit: It is probably worth using |
I had overseen the code you referenced somehow, thanks for the clarification John 🙏 @GenevieveBuckley Would you like me to help completing this PR? |
PR #370 adds python 3.12 support. This PR should also have python 3.12 support. |
Sorry I didn't see your message earlier @m-albert |
…ong term support)
Decision: I'm going to try replacing versioneer with setuptools-scm as part of this PR. |
…timeout mark will not be recognised)
Ok, done. There's still a few GPU CI things left to take care of, and that work is happening in separate PRs. |
Hooray! 🎉 Thanks Genevieve! 🙏 |
Closes #305