Fix overflow ensuring visibility and proper positioning of action buttons in WidgetHeader component #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -35,13 +35,15 @@ export function WidgetHeader({ | |||
|
|
|||
| return ( | |||
| <div className="flex justify-between items-start w-full"> | |||
| <div className="flex flex-1 w-full gap-2"> | |||
| <div className="flex flex-1 items-center overflow-hidden w-full gap-2"> | |||
There was a problem hiding this comment.
Suggested change
| <div className="flex flex-1 items-center overflow-hidden w-full gap-2"> | |
| <div className="flex flex-1 overflow-hidden w-full gap-2"> |
| {setting && ( | ||
| <SortableKnob> | ||
| <GrabIcon width={18} /> | ||
| </SortableKnob> | ||
| )} | ||
| <p className="truncate w-[calc(100%-1px)]">{title} TODO</p> | ||
| <p className="truncate max-w-[calc(100%-5px)] w-full "> |
There was a problem hiding this comment.
Suggested change
| <p className="truncate max-w-[calc(100%-5px)] w-full "> | |
| <p className="truncate"> |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
when the title attains a certain length it pushes the the action button out of the box which distort the UI and positioning of the action button
Issue Number: N/A
What is the new behavior?
it has been enhanced to hide the overflow of the truncated value when it has overflowed a certain fixed width.
Does this introduce a breaking change?
Other information