Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move permission hierarchy to the FE #49

Merged
merged 3 commits into from
Oct 20, 2023
Merged

feat: move permission hierarchy to the FE #49

merged 3 commits into from
Oct 20, 2023

Conversation

Ktbch
Copy link
Contributor

@Ktbch Ktbch commented Oct 20, 2023 •
edited
Loading

I implemented the permissions hierarchy functionality from the front-end which was the back-end

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • [. ] Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Tests
  • Other (please describe):

What is the current behavior?

the permission hierarchy feature is now implemented from the back-end code

Issue Number: N/A

What is the new behavior?

the permission hierarchy feature is now implemented from the front-end code

Does this introduce a breaking change?

  • Yes
  • No

Other information

thrownullexception
thrownullexception approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@thrownullexception thrownullexception left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done!
Thanks for your contribution!

@thrownullexception thrownullexception added the enhancement New feature or request label Oct 20, 2023
@thrownullexception thrownullexception changed the title permissions changes feat: move permission hierarchy to the FE Oct 20, 2023
@thrownullexception thrownullexception merged commit 2e19cc4 into dashpresshq:master Oct 20, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrownullexception thrownullexception thrownullexception approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ktbch @thrownullexception