✨ feat(upload): file uploads configurations

dashpresshq · Nov 21, 2023 · fd8993f · fd8993f
1 parent 187da28
commit fd8993f
Show file tree

Hide file tree

Showing 56 changed files with 546 additions and 850 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/__tests__/api/_test-utils/_activated-storage.ts b/src/__tests__/api/_test-utils/_activated-storage.ts
diff --git a/src/__tests__/api/_test-utils/_all.ts b/src/__tests__/api/_test-utils/_all.ts
@@ -10,7 +10,6 @@ import { setupUsersTestData } from "./_users";
 import { setupIntegrationsEnvTestData } from "./_integrations-env";
 import { setupActivatedActionTestData } from "./_activated-actions";
 import { setupActionInstanceTestData } from "./_action-instances";
-import { setupActivatedStorageTestData } from "./_activated-storage";
 import { setupTestDatabaseData } from "./_data";
 import { portalTestData } from "./portal";
 
@@ -25,7 +24,6 @@ export const setupAllTestData = async (domains: DomainTypes[]) => {
     ["schema", setupSchemaTestData],
     ["data", setupTestDatabaseData],
     ["activated-actions", setupActivatedActionTestData],
-    ["activated-storage", setupActivatedStorageTestData],
     ["action-instances", setupActionInstanceTestData],
     ["constants", setupIntegrationsConstantsTestData],
     ["environment-variables", setupIntegrationsEnvTestData],

diff --git a/src/__tests__/api/integrations/storage/[key]/index.spec.ts b/src/__tests__/api/integrations/storage/[key]/index.spec.ts
@@ -1,16 +1,14 @@
 import handler from "pages/api/integrations/storage/[key]/index";
 import activeHandler from "pages/api/integrations/storage/active";
-import credentialsHandler from "pages/api/integrations/storage/[key]/credentials";
+import credentialsHandler from "pages/api/integrations/storage/credentials";
 import {
   createAuthenticatedMocks,
   setupAllTestData,
 } from "__tests__/api/_test-utils";
-import { setupActivatedStorageTestData } from "__tests__/api/_test-utils/_activated-storage";
 
 describe("/api/integrations/actions/[key]/index", () => {
   beforeAll(async () => {
     await setupAllTestData(["users"]);
-    await setupActivatedStorageTestData([{ key: "google" }, { key: "minio" }]);
   });
 
   describe("POST", () => {
@@ -43,21 +41,6 @@ describe("/api/integrations/actions/[key]/index", () => {
         `);
       });
 
-      it("should not show the activated storage in list", async () => {
-        const { req: activeReq, res: activeRes } = createAuthenticatedMocks({
-          method: "GET",
-        });
-
-        await activeHandler(activeReq, activeRes);
-
-        expect(activeRes._getJSONData()).toMatchInlineSnapshot(`
-            [
-              "google",
-              "minio",
-            ]
-          `);
-      });
-
       it("should not save the credentials", async () => {
         const { req: credentialsReq, res: credentialsRes } =
           createAuthenticatedMocks({
@@ -237,58 +220,4 @@ describe("/api/integrations/actions/[key]/index", () => {
           `);
     });
   });
-
-  describe("DELETE", () => {
-    it("should deactivate activated storage", async () => {
-      const { req, res } = createAuthenticatedMocks({
-        method: "DELETE",
-        query: {
-          key: "s3",
-        },
-      });
-      await handler(req, res);
-
-      expect(res._getStatusCode()).toBe(204);
-    });
-
-    it("should remove activated action", async () => {
-      const { req: activeReq, res: activeRes } = createAuthenticatedMocks({
-        method: "GET",
-      });
-
-      await activeHandler(activeReq, activeRes);
-
-      expect(activeRes._getJSONData()).toMatchInlineSnapshot(`
-        [
-          "google",
-          "minio",
-        ]
-      `);
-    });
-
-    it("should remove access to credentials", async () => {
-      const { req: credentialsReq, res: credentialsRes } =
-        createAuthenticatedMocks({
-          method: "POST",
-          query: {
-            key: "s3",
-          },
-          body: {
-            _password: "password",
-          },
-        });
-      await credentialsHandler(credentialsReq, credentialsRes);
-
-      expect(credentialsRes._getStatusCode()).toBe(400);
-      expect(credentialsRes._getJSONData()).toMatchInlineSnapshot(`
-        {
-          "message": "No credentials available for AWS_S3",
-          "method": "POST",
-          "name": "BadRequestError",
-          "path": "",
-          "statusCode": 400,
-        }
-      `);
-    });
-  });
 });
diff --git a/src/__tests__/api/integrations/storage/active.spec.ts b/src/__tests__/api/integrations/storage/active.spec.ts
diff --git a/src/backend/actions/actions.service.ts b/src/backend/actions/actions.service.ts
@@ -26,6 +26,7 @@ import {
 } from "shared/types/actions";
 import { IAccountProfile } from "shared/types/user";
 import { compileTemplateString } from "shared/lib/strings/templates";
+import { sluggify } from "shared/lib/strings";
 import { ACTION_INTEGRATIONS } from "./integrations";
 
 export class ActionsApiService implements IApplicationService {
@@ -206,8 +207,8 @@ export class ActionsApiService implements IApplicationService {
     );
 
     const activationId = nanoid();
-    const credentialsGroupKey =
-      ACTION_INTEGRATIONS[integrationKey].credentialsKey;
+
+    const credentialsGroupKey = this.makeCredentialsGroupKey(integrationKey);
 
     await this._activatedActionsPersistenceService.createItem(activationId, {
       activationId,
@@ -226,6 +227,10 @@ export class ActionsApiService implements IApplicationService {
     );
   }
 
+  private makeCredentialsGroupKey(integrationKey: ActionIntegrationKeys) {
+    return sluggify(`ACTION__${integrationKey}`).toUpperCase();
+  }
+
   private async getIntegrationKeyFromActivatedActionId(
     activatedActionId: string
   ): Promise<string> {

diff --git a/src/backend/actions/integrations/http/index.ts b/src/backend/actions/integrations/http/index.ts
@@ -36,7 +36,6 @@ const ACTION_CONFIGURATION_SCHEMA: IAppliedSchemaFormConfig<IAction> = {
 
 export const HTTP_ACTION_INTEGRATION: IActionIntegrationsImplemention = {
   title: "HTTP",
-  credentialsKey: "HTTP",
   description: "Performs HTTP request",
   configurationSchema: {},
   connect: async () => {},