🧪 test(general): cleanup todos

dashpresshq · Dec 1, 2023 · e6b5a33 · e6b5a33
1 parent 08260e4
commit e6b5a33
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 15 deletions.
diff --git a/src/__tests__/api/_test-utils/_all.ts b/src/__tests__/api/_test-utils/_all.ts
@@ -43,4 +43,4 @@ export const setupAllTestData = async (domains: DomainTypes[]) => {
   );
 };
 
-// TODO: test all custom script logic
+// TEST: test all custom script logic
diff --git a/src/__tests__/api/menu/index.spec.ts b/src/__tests__/api/menu/index.spec.ts
@@ -155,4 +155,4 @@ describe("/api/menu", () => {
   });
 });
 
-// TODO: test isMenuItemAllowed
+// TEST: test isMenuItemAllowed
diff --git a/src/__tests__/roles/[roleId]/index.spec.tsx b/src/__tests__/roles/[roleId]/index.spec.tsx
@@ -296,5 +296,5 @@ describe("pages/roles/[roleId]/index", () => {
     ).toBeChecked();
   });
 
-  // todo test heirachy
+  // TEST: test heirachy
 });
diff --git a/src/backend/users/users.controller.ts b/src/backend/users/users.controller.ts
@@ -64,7 +64,6 @@ export class UsersApiController {
     }
   }
 
-  // TODO: if mail is activated then send reset form
   async resetPassword(username: string, input: IResetPasswordForm) {
     await this._usersService.resetPassword(username, input.password);
   }

diff --git a/src/frontend/design-system/components/Table/filters/_FilterOperator.tsx b/src/frontend/design-system/components/Table/filters/_FilterOperator.tsx
@@ -13,7 +13,7 @@ const FILTER_OPERATOR_LABELS: Record<FilterOperators, string> = {
   [FilterOperators.BETWEEN]: "Between",
   [FilterOperators.CONTAINS]: "Contains",
   [FilterOperators.NOT_EQUAL]: "Not Equal To",
-  [FilterOperators.IS_NULL]: "Is Null", // TODO:
+  [FilterOperators.IS_NULL]: "Is Null",
 };
 
 interface IProps<T> {

diff --git a/src/frontend/views/data/Table/useTableMenuItems.ts b/src/frontend/views/data/Table/useTableMenuItems.ts
@@ -18,7 +18,7 @@ export const useTableMenuItems = (
   const entityCrudConfig = useEntityCrudConfig(entity);
   const canUserPerformCrudAction = useCanUserPerformCrudAction(entity);
 
-  const pluginTableMenuItems = usePluginTableMenuItems(entity);
+  const pluginTableMenuItems = usePluginTableMenuItems(entity, reference);
 
   if (entity === SLUG_LOADING_VALUE) {
     return [];
@@ -35,15 +35,11 @@ export const useTableMenuItems = (
       label: entityCrudConfig.TEXT_LANG.CREATE,
       IconComponent: Plus,
       onClick: () => {
+        let baseUrl = NAVIGATION_LINKS.ENTITY.CREATE(entity);
         if (reference) {
-          router.push(
-            `${NAVIGATION_LINKS.ENTITY.CREATE(entity)}?${
-              reference.referenceField
-            }=${reference.entityId}`
-          );
-          return;
+          baseUrl = `${baseUrl}?${reference.referenceField}=${reference.entityId}`;
         }
-        router.push(NAVIGATION_LINKS.ENTITY.CREATE(entity));
+        router.push(baseUrl);
       },
     });
   }

diff --git a/src/frontend/views/entity/Actions/Form.tsx b/src/frontend/views/entity/Actions/Form.tsx
@@ -178,7 +178,7 @@ export function ActionForm({
 
         await onSubmit({ ...cleanedConfigurationForm, integrationKey });
       }}
-      // TODO unit test this
+      // TEST: unit test this
       formExtension={{
         fieldsState: `
             return {

diff --git a/src/frontend/views/integrations/storage/General.tsx b/src/frontend/views/integrations/storage/General.tsx
@@ -34,7 +34,7 @@ export function GeneralStorageSettings() {
         />
       }
     >
-      {/* TODO: document */}
+      {/* TODO: documentation */}
       <SchemaForm<IFileUploadSettings>
         initialValues={fileUploadSettings.data}
         fields={{
-Original file line number
+Diff line change
@@ Expand Up @@
       );
     };
-    // TODO: test all custom script logic
+    // TEST: test all custom script logic