♻️ refactor(bootstrap): remove bootsrap calls

src/backend/configuration/configuration.service.ts

@@ -1,4 +1,3 @@
-import { IApplicationService } from "backend/types";
 import { progammingError } from "backend/lib/errors";
 import { AppConfigurationValueType } from "shared/configurations/constants";
 import {
@@ -12,15 +11,11 @@ import {
   AppConfigurationKeys,
 } from "../../shared/configurations";
 
-export class ConfigurationApiService implements IApplicationService {
+export class ConfigurationApiService {
   constructor(
     private _appConfigPersistenceService: AbstractConfigDataPersistenceService<unknown>
   ) {}
 
-  async bootstrap() {
-    await this._appConfigPersistenceService.setup();
-  }
-
   async show<T extends AppConfigurationKeys>(
     key: T,
     entity?: string

src/backend/dashboard-widgets/dashboard-widgets.service.ts

@@ -6,7 +6,6 @@ import {
   createConfigDomainPersistenceService,
   AbstractConfigDataPersistenceService,
 } from "backend/lib/config-persistence";
-import { IApplicationService } from "backend/types";
 import {
   HOME_DASHBOARD_KEY,
   IWidgetConfig,
@@ -52,7 +51,7 @@ const runAsyncJavascriptString = async (
   }
 };
 
-export class DashboardWidgetsApiService implements IApplicationService {
+export class DashboardWidgetsApiService {
   constructor(
     private readonly _dashboardWidgetsPersistenceService: AbstractConfigDataPersistenceService<IWidgetConfig>,
     private readonly _entitiesApiService: EntitiesApiService,
@@ -61,10 +60,6 @@ export class DashboardWidgetsApiService implements IApplicationService {
     private readonly _rDBMSApiDataService: RDBMSDataApiService
   ) {}
 
-  async bootstrap() {
-    await this._dashboardWidgetsPersistenceService.setup();
-  }
-
   async runScript(
     script$1: string,
     currentUser: IAccountProfile,

src/backend/data/data.service.ts

@@ -33,7 +33,7 @@ export class DataApiService implements IDataApiService {
     private _configurationApiService: ConfigurationApiService
   ) {}
 
-  async bootstrap() {
+  async runOnLoad() {
     await this.getDataAccessInstance().bootstrap();
   }
 

src/backend/data/types.ts

@@ -1,4 +1,3 @@
-import { IApplicationService } from "backend/types";
 import { PaginatedData, QueryFilterSchema } from "shared/types/data";
 import { IAccountProfile } from "shared/types/user";
 
@@ -11,7 +10,7 @@ export interface IPaginationFilters {
 
 export const FOR_CODE_COV = 1;
 
-export interface IDataApiService extends IApplicationService {
+export interface IDataApiService {
   fetchData(
     entity: string,
     select: string[],

src/backend/entities/entities.service.ts

@@ -4,26 +4,20 @@ import {
   ConfigurationApiService,
 } from "backend/configuration/configuration.service";
 import { rolesApiService, RolesApiService } from "backend/roles/roles.service";
-import { IApplicationService } from "backend/types";
-import { noop } from "shared/lib/noop";
 import { IDBSchema, IEntityField, IEntityRelation } from "shared/types/db";
 import { DataCrudKeys } from "shared/types/data";
 import { CRUD_HIDDEN_KEY_CONFIG } from "shared/configurations/permissions";
 import { sortListByOrder } from "shared/lib/array/sort";
 import { SchemasApiService, schemasApiService } from "../schema/schema.service";
 import { PortalFieldsFilterService } from "./portal";
 
-export class EntitiesApiService implements IApplicationService {
+export class EntitiesApiService {
   constructor(
     private _schemasApiService: SchemasApiService,
     private _configurationApiService: ConfigurationApiService,
     private _rolesApiService: RolesApiService
   ) {}
 
-  async bootstrap() {
-    noop();
-  }
-
   private async getDBSchemaModels(): Promise<Record<string, IDBSchema>> {
     return Object.fromEntries(
       (await this._schemasApiService.getDBSchema()).map((model) => [

src/backend/form-actions/form-actions.service.ts

@@ -2,19 +2,14 @@ import {
   createConfigDomainPersistenceService,
   AbstractConfigDataPersistenceService,
 } from "backend/lib/config-persistence";
-import { IApplicationService } from "backend/types";
 import { nanoid } from "nanoid";
 import { IFormAction } from "shared/types/actions";
 
-export class FormActionsApiService implements IApplicationService {
+export class FormActionsApiService {
   constructor(
     private readonly _formActionsPersistenceService: AbstractConfigDataPersistenceService<IFormAction>
   ) {}
 
-  async bootstrap() {
-    await this._formActionsPersistenceService.setup();
-  }
-
   async createFormAction(action: Omit<IFormAction, "id">) {
     const id = nanoid();
 

src/backend/integrations-configurations/services/_base.ts

@@ -1,30 +1,18 @@
 import { AbstractConfigDataPersistenceService } from "backend/lib/config-persistence";
 import { EncryptionApiService } from "backend/lib/encryption/encryption.service";
 import { BadRequestError, progammingError } from "backend/lib/errors";
-import { IApplicationService } from "backend/types";
-import { noop } from "shared/lib/noop";
 import { IGroupCredential } from "../types";
 
 export const INTEGRATION_CONFIG_GROUP_DEMILITER = "___";
 
-export abstract class IntegrationsConfigurationApiService
-  implements IApplicationService
-{
+export abstract class IntegrationsConfigurationApiService {
   constructor(
     protected _persistenceService: AbstractConfigDataPersistenceService<string>,
     protected _encryptionApiService: EncryptionApiService
   ) {}
 
   static GROUP_DEMILITER = INTEGRATION_CONFIG_GROUP_DEMILITER;
 
-  async bootstrap() {
-    try {
-      await this._persistenceService.setup();
-    } catch (error) {
-      noop();
-    }
-  }
-
   async hasKey(key: string): Promise<boolean> {
     return (await this.getValue(key)) !== undefined;
   }

src/backend/integrations/integrations.service.ts

@@ -13,15 +13,13 @@ import {
   createKeyValueDomainPersistenceService,
   KeyValueStoreApiService,
 } from "backend/lib/key-value";
-import { IApplicationService } from "backend/types";
-import { noop } from "shared/lib/noop";
 import {
   formActionsApiService,
   FormActionsApiService,
 } from "backend/form-actions/form-actions.service";
 import { ACTION_INTEGRATIONS } from "./libs";
 
-export class IntegrationsApiService implements IApplicationService {
+export class IntegrationsApiService {
   constructor(
     private readonly _activatedIntegrationsPersistenceService: KeyValueStoreApiService<
       ActionIntegrations[]
@@ -30,10 +28,6 @@ export class IntegrationsApiService implements IApplicationService {
     private readonly _formActionsApiService: FormActionsApiService
   ) {}
 
-  async bootstrap() {
-    noop();
-  }
-
   listActionIntegrations(): IIntegrationsList[] {
     return Object.entries(ACTION_INTEGRATIONS).map(
       ([key, { title, description, configurationSchema }]) => ({

src/backend/lib/config-persistence/AbstractConfigDataPersistenceService.ts

@@ -10,8 +10,6 @@ export abstract class AbstractConfigDataPersistenceService<T> {
 
   protected readonly _configApiService!: ConfigApiService;
 
-  public abstract setup(): Promise<void>;
-
   constructor(configDomain: ConfigDomain, configApiService: ConfigApiService) {
     this._configDomain = configDomain;
     this._configApiService = configApiService;

src/backend/lib/config-persistence/DatabaseConfigDataPersistenceAdaptor.ts

@@ -57,10 +57,6 @@ export class DatabaseConfigDataPersistenceAdaptor<
     return DatabaseConfigDataPersistenceAdaptor._dbInstance;
   }
 
-  async setup() {
-    await this.getDbInstance();
-  }
-
   async _resetToEmpty() {
     await (await this.getDbInstance())(CONFIG_TABLE_NAME)
       .where("domain", "=", this._configDomain)

src/backend/lib/config-persistence/JsonFileConfigDataPersistenceAdaptor.ts

@@ -1,5 +1,4 @@
 import fs from "fs-extra";
-import { noop } from "shared/lib/noop";
 import path from "path";
 import { ConfigApiService } from "../config/config.service";
 
@@ -13,10 +12,6 @@ export class JsonFileConfigDataPersistenceAdaptor<
     super(configDomain, configApiService);
   }
 
-  async setup() {
-    noop();
-  }
-
   private pathToConfigDomain = (type: ConfigDomain) => {
     const file =
       this._configApiService.getNodeEnvironment() === "test"

src/backend/lib/config-persistence/MemoryConfigDataPersistenceAdaptor.ts

@@ -1,4 +1,3 @@
-import { noop } from "shared/lib/noop";
 import { ConfigApiService } from "../config/config.service";
 import { AbstractConfigDataPersistenceService } from "./AbstractConfigDataPersistenceService";
 import { ConfigDomain } from "./types";
@@ -12,10 +11,6 @@ export class MemoryConfigDataPersistenceAdaptor<
     super(configDomain, configApiService);
   }
 
-  async setup() {
-    noop();
-  }
-
   getItemLastUpdated() {
     return null;
   }

src/backend/lib/config-persistence/RedisConfigDataPersistenceAdaptor.ts

@@ -32,10 +32,6 @@ export class RedisConfigDataPersistenceAdaptor<
     return null;
   }
 
-  async setup() {
-    await this.getRedisInstance();
-  }
-
   constructor(configDomain: ConfigDomain, _configApiService: ConfigApiService) {
     super(configDomain, _configApiService);
   }

src/backend/lib/config/config.service.ts

@@ -16,14 +16,10 @@ export class ConfigApiService {
 
   constructor(protected processEnv: Record<string, unknown>) {
     if (!this.processEnv.DO_NOT_BOOSTRAP_CONFIG) {
-      this.bootstrap();
+      this.assertConfiguration();
     }
   }
 
-  bootstrap() {
-    this.assertConfiguration();
-  }
-
   getConfigValue<T>(key: ConfigKeys): T {
     return this.processEnv[key] as unknown as T;
   }

src/backend/lib/temp-storage/index.ts

@@ -14,10 +14,6 @@ export class TempStorageApiService {
     private readonly _tempStoragePersistenceService: AbstractConfigDataPersistenceService<ITempStorage>
   ) {}
 
-  async bootstrap() {
-    await this._tempStoragePersistenceService.setup();
-  }
-
   async clearItem(key: string) {
     await this._tempStoragePersistenceService.removeItem(key);
   }

src/backend/list-order/list-order.service.ts

@@ -2,19 +2,14 @@ import {
   createConfigDomainPersistenceService,
   AbstractConfigDataPersistenceService,
 } from "backend/lib/config-persistence";
-import { IApplicationService } from "backend/types";
 
-export class ListOrderApiService implements IApplicationService {
+export class ListOrderApiService {
   constructor(
     private readonly _listOrderPersistenceService: AbstractConfigDataPersistenceService<
       string[]
     >
   ) {}
 
-  async bootstrap() {
-    await this._listOrderPersistenceService.setup();
-  }
-
   async getItemOrder(listId: string): Promise<string[]> {
     return await this._listOrderPersistenceService.getItem(listId, []);
   }

src/backend/menu/menu.service.ts

@@ -1,4 +1,3 @@
-import { IApplicationService } from "backend/types";
 import { nanoid } from "nanoid";
 import {
   INavigationMenuItem,
@@ -12,7 +11,6 @@ import {
   EntitiesApiService,
   entitiesApiService,
 } from "backend/entities/entities.service";
-import { noop } from "shared/lib/noop";
 import {
   ConfigurationApiService,
   configurationApiService,
@@ -46,19 +44,13 @@ const SYSTEM_LINKS_CONFIG_MAP: Record<
   },
 };
 
-export class NavigationMenuApiService
-  implements IApplicationService, IBaseNavigationMenuApiService
-{
+export class NavigationMenuApiService implements IBaseNavigationMenuApiService {
   constructor(
     private readonly _entitiesApiService: EntitiesApiService,
     private readonly _configurationApiService: ConfigurationApiService,
     private readonly _rolesApiService: RolesApiService
   ) {}
 
-  async bootstrap() {
-    noop();
-  }
-
   async getMenuItems(userRole: string) {
     const portalMenuItems = await getPortalMenuItems(userRole, this);
 

src/backend/roles/roles.service.ts

@@ -3,7 +3,6 @@ import {
   AbstractConfigDataPersistenceService,
 } from "backend/lib/config-persistence";
 import { BadRequestError } from "backend/lib/errors";
-import { IApplicationService } from "backend/types";
 import { canRoleDoThisAsync } from "shared/logic/permissions";
 import {
   isSystemRole,
@@ -18,15 +17,11 @@ export interface IRole {
   permissions: string[];
 }
 
-export class RolesApiService implements IApplicationService {
+export class RolesApiService {
   constructor(
     private readonly _rolesPersistenceService: AbstractConfigDataPersistenceService<IRole>
   ) {}
 
-  async bootstrap() {
-    await this._rolesPersistenceService.setup();
-  }
-
   async listRoles(): Promise<string[]> {
     const roles = await this._rolesPersistenceService.getAllItems();
 

src/backend/schema/schema.service.ts

@@ -3,7 +3,6 @@ import {
   CredentialsApiService,
   credentialsApiService,
 } from "backend/integrations-configurations";
-import { IApplicationService } from "backend/types";
 import { IDBSchema, IEntityField } from "shared/types/db";
 import { IDataSourceCredentials } from "shared/types/data-sources";
 import { DATABASE_CREDENTIAL_GROUP } from "backend/data/fields";
@@ -13,16 +12,15 @@ import {
   AbstractConfigDataPersistenceService,
 } from "../lib/config-persistence";
 
-export class SchemasApiService implements IApplicationService {
+export class SchemasApiService {
   private dbSchema: IDBSchema[];
 
   constructor(
     private _schemaConfigDataPersistenceService: AbstractConfigDataPersistenceService<IDBSchema>,
     private _credentialsService: CredentialsApiService
   ) {}
 
-  async bootstrap() {
-    await this._schemaConfigDataPersistenceService.setup();
+  async runOnLoad() {
     await this.loadDbSchema();
   }