🐛 fix(storage): remove credentials UI

dashpresshq · Apr 11, 2024 · 3902d90 · 3902d90
1 parent fba2fd5
commit 3902d90
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 21 deletions.
diff --git a/src/__tests__/_/forCodeCoverage.spec.ts b/src/__tests__/_/forCodeCoverage.spec.ts
@@ -40,6 +40,7 @@ import { FOR_CODE_COV as $46 } from "shared/constants/portal/menu/main";
 import { FOR_CODE_COV as $47 } from "shared/constants/portal/menu/index";
 import { FOR_CODE_COV as $48 } from "shared/user-preferences/base-types";
 import { FOR_CODE_COV as $49 } from "shared/user-preferences/types";
+import { FOR_CODE_COV as $50 } from "frontend/design-system/components/EmptyWrapper/types";
 
 import { noop } from "shared/lib/noop";
 
@@ -85,7 +86,8 @@ noop(
   $46,
   $47,
   $48,
-  $49
+  $49,
+  $50
 );
 
 describe("Code coverage ignores plain types file", () => {

diff --git a/src/frontend/_layouts/guest/_partials/GuestHeader/index.tsx b/src/frontend/_layouts/guest/_partials/GuestHeader/index.tsx
@@ -18,7 +18,7 @@ const Root = styled(CardBody)`
 
 interface IProps {
   title: string;
-  subTitle?: string;
+  subTitle: string;
   fullLogo?: string;
   homeLink?: string;
 }
@@ -37,7 +37,7 @@ export function GuestHeader({
         <Spacer />
         <Typo.MD color="inverse">{title}</Typo.MD>
         <Spacer size="xs" />
-        {subTitle ? <Typo.XS color="inverse">{subTitle}</Typo.XS> : null}
+        <Typo.XS color="inverse">{subTitle}</Typo.XS>
       </a>
     </Root>
   );

diff --git a/src/frontend/design-system/components/EmptyWrapper/types.ts b/src/frontend/design-system/components/EmptyWrapper/types.ts
@@ -2,3 +2,5 @@ export interface IEmptyWrapperProps {
   text: string;
   createNew?: { action: string | (() => void); label: string };
 }
+
+export const FOR_CODE_COV = 1;
diff --git a/src/frontend/views/integrations/storage/Credentials.tsx b/src/frontend/views/integrations/storage/Credentials.tsx
@@ -7,7 +7,6 @@ import {
   FormSkeletonSchema,
 } from "frontend/design-system/components/Skeleton/Form";
 import { ISchemaFormConfig } from "shared/form-schemas/types";
-import { noop } from "shared/lib/noop";
 import { IStorageIntegration } from "shared/types/actions";
 import { STORAGE_INTEGRATIONS_CRUD_CONFIG } from "./constants";
 import {
@@ -71,23 +70,10 @@ export function StorageCredentialsSettings() {
       }
     >
       {storageCredentialsConfiguration.data === undefined ? (
-        <>
-          <SchemaForm<{ storageKey: string }>
-            fields={{
-              storageKey: storageFormConfig,
-            }}
-            onSubmit={async () => noop()}
-            initialValues={{
-              storageKey: currentStorage,
-            }}
-            buttonText={null}
-            systemIcon="Save"
-          />
-          <PasswordToReveal
-            label={`${STORAGE_INTEGRATIONS_CRUD_CONFIG.TEXT_LANG.TITLE} Configuration`}
-            isLoading={storageCredentialsConfiguration.isLoading}
-          />
-        </>
+        <PasswordToReveal
+          label={`${STORAGE_INTEGRATIONS_CRUD_CONFIG.TEXT_LANG.TITLE} Configuration`}
+          isLoading={storageCredentialsConfiguration.isLoading}
+        />
       ) : (
         <SchemaForm<{ storageKey: string }>
           fields={{