Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mempool): cancel previous mempool run when starting new one #760

Merged
merged 20 commits into from
Mar 12, 2024
Merged

fix(mempool): cancel previous mempool run when starting new one #760

merged 20 commits into from
Mar 12, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Mar 12, 2024 •
edited
Loading

Issue being fixed or feature implemented

Under load, recheck tx runs might not finish before next block is finalized. In this case, second set of recheck tx tasks is started in parallel.

What was done?

Cancel previous run of recheck tx when starting new one.

How Has This Been Tested?

During dash drive load tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek added 16 commits March 8, 2024 11:35
@lklimek
feat(p2p): throttled channel
0aa9937 
(cherry picked from commit 5e41958)
@lklimek
feat: limit mempool broadcast to 5/s
dfab3a4 
(cherry picked from commit cdde233)
@lklimek
feat(p2p): channel recv rate limiting - not tested
c06656c 
(cherry picked from commit f7f7ce7)
@lklimek
feat(p2p): channel recv rate limiting - continued
73286e9 
(cherry picked from commit 54e00f7)
@lklimek
chore(p2p): regen channel mocks
c128637
@lklimek
feat(config): mempool tx-send-rate-limit, tx-recv-rate-limit, tx-recv…
5ffb024 
…-rate-punish-peer
@lklimek
chore: lint
aa82ab9
@lklimek
chore(mempool): burst recv twice as big as burst send
7fef019
@lklimek
chore: lint
1c1631b
@lklimek
chore: remove not needed log
7d6aba7
@lklimek
Merge remote-tracking branch 'origin/v0.14-dev' into feat/rate-limiti…
50dfc1c 
…ng-channels
@lklimek
chore: fixes after merge
e75088d
@lklimek
refactor(p2p): move chan descs to p2p.channel_params and tune priorities
d2bf391
@lklimek
chore: fix after merge
cc6bfde
@lklimek
chore(statesync): fix linter issues - remove unused consts
9e5cf6c
@lklimek
fix(mempool): cancel previous mempool run when starting new one
7764b63
Base automatically changed from refactor/move-channel-definitions to v0.14-dev March 12, 2024 16:07
@lklimek lklimek enabled auto-merge (squash) March 12, 2024 16:07
shumkov
shumkov approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit ebe4523 into v0.14-dev Mar 12, 2024
15 checks passed
@lklimek lklimek deleted the fix/mempool-recheck-not-stopped branch March 13, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lklimek @shumkov