Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libs): go-deadlock slows down clist #747

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Mar 5, 2024

Issue being fixed or feature implemented

Under load, Tenderdash slows down significantly due to expensive logic inside go-deadlock, used in clist object.

go-deadlock processes backtrace, with takes much resources.

What was done?

go-deadlock not used in clist library

How Has This Been Tested?

Tested during performance tests and tuning of Dash Drive.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title fix: go-deadlock slows down clist fix(libs): go-deadlock slows down clist Mar 5, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 9749779 into v0.14-dev Mar 5, 2024
15 checks passed
@lklimek lklimek deleted the fix/clist-lock-bottleneck branch March 5, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants