fix(consensus): invalid block height gossiped to lagging peer

dashpay · Mar 13, 2024 · 9eeddf9 · 9eeddf9
1 parent 2fb9bf7
commit 9eeddf9
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/internal/consensus/gossip_handlers.go b/internal/consensus/gossip_handlers.go
@@ -117,9 +117,14 @@ func shouldProposalBeGossiped(rs cstypes.RoundState, prs *cstypes.PeerRoundState
 }
 
 func shouldBlockPartsBeGossiped(rs cstypes.RoundState, prs *cstypes.PeerRoundState, isValidator bool) bool {
+	if rs.Height != prs.Height || rs.Round < prs.Round {
+		return false
+	}
+
 	if isValidator && rs.ProposalBlockParts.HasHeader(prs.ProposalBlockPartSetHeader) {
 		return true
 	}
+
 	return prs.HasCommit && rs.ProposalBlockParts != nil
 }