fix(node): validator conn executor not started correctly

node/node.go

@@ -73,9 +73,6 @@ type nodeImpl struct {
 	shutdownOps    closer
 	rpcEnv         *rpccore.Environment
 	prometheusSrv  *http.Server
-
-	// Dash
-	validatorConnExecutor *dashquorum.ValidatorConnExecutor
 }
 
 // newDefaultNode returns a Tendermint node with default settings for the
@@ -254,6 +251,8 @@ func makeNode(
 		if err != nil {
 			return nil, combineCloseError(err, makeCloser(closers))
 		}
+	} else {
+		logger.Debug("ProTxHash not set, so we are not a validator; skipping ValidatorConnExecutor initialization")
 	}
 
 	// TODO construct node here:
@@ -268,16 +267,14 @@ func makeNode(
 
 		eventSinks:     eventSinks,
 		indexerService: indexerService,
-		services:       []service.Service{eventBus},
+		services:       []service.Service{eventBus, validatorConnExecutor},
 
 		initialState: state,
 		stateStore:   stateStore,
 		blockStore:   blockStore,
 
 		shutdownOps: makeCloser(closers),
 
-		validatorConnExecutor: validatorConnExecutor,
-
 		rpcEnv: &rpccore.Environment{
 			ProxyApp: proxyApp,
 

node/node_test.go

@@ -672,7 +672,7 @@ func TestNodeSetEventSink(t *testing.T) {
 
 	logger := log.NewNopLogger()
 
-	setupTest := func(t *testing.T, conf *config.Config) []indexer.EventSink {
+	setupTest := func(t *testing.T, _conf *config.Config) []indexer.EventSink {
 		eventBus := eventbus.NewDefault(logger.With("module", "events"))
 		require.NoError(t, eventBus.Start(ctx))