Merge remote-tracking branch 'origin/v0.14-dev' into fix-mempool-spam

dashpay · Mar 13, 2024 · 5fb90a7 · 5fb90a7
2 parents 3749b9d + 220c648
commit 5fb90a7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/state/execution.go b/internal/state/execution.go
@@ -256,12 +256,12 @@ func (blockExec *BlockExecutor) CreateProposalBlock(
 	)
 	if bytes.Equal(blockExec.lastRequestPrepareProposalHash, reqHash) &&
 		!bytes.Equal(blockExec.lastResponsePrepareProposalHash, respHash) {
+		// we don't panic here, as we don't want to break this node and
+		// remove it from voting quorum
 		blockExec.logger.Error("PrepareProposal response is non-deterministic",
 			"request_hash", hex.EncodeToString(reqHash),
 			"response_hash", hex.EncodeToString(respHash),
 		)
-		// TODO: Remove panic after we find the root cause of the non-determinism
-		panic("PrepareProposal response is non-deterministic")
 	}
 
 	if err := rpp.Validate(); err != nil {