feat(p2p): channel recv rate limiting - continued

dashpay · Feb 16, 2024 · 54e00f7 · 54e00f7
1 parent 623706e
commit 54e00f7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/internal/p2p/channel.go b/internal/p2p/channel.go
@@ -377,12 +377,14 @@ func (tci *throttledChannelIterator) Next(ctx context.Context) bool {
 		}
 		e := tci.innerIter.Envelope()
 		if tci.reportErr && e != nil {
-			tci.innerChan.SendError(ctx, PeerError{
+			msg := PeerError{
 				NodeID: e.From,
 				Err:    ErrRecvRateLimitExceeded,
-				Fatal:  false,
-			})
-
+				Fatal:  true,
+			}
+			if err := tci.innerChan.SendError(ctx, msg); err != nil {
+				tci.logger.Error("error sending error message", "err", err, "msg", msg)
+			}
 		} else {
 			tci.logger.Trace("dropping message due to rate limit", "channel", tci.innerChan, "rate", tci.limiter.Limit())
 		}

diff --git a/internal/p2p/channel_params.go b/internal/p2p/channel_params.go
@@ -82,8 +82,8 @@ func ChannelDescriptors(cfg *config.Config) map[ChannelID]*ChannelDescriptor {
 			Name:                "mempool",
 			SendRateLimit:       5,    // TODO: make it configurable
 			SendRateBurst:       20,   // TODO: make it configurable
-			RecvRateLimit:       1,    // TODO: make it configurable
-			RecvRateBurst:       1,    // TODO: make it configurable
+			RecvRateLimit:       10,   // TODO: make it configurable
+			RecvRateBurst:       100,  // TODO: make it configurable
 			RecvRateShouldErr:   true, // TODO: make it configurable
 			EnqueueTimeout:      10 * time.Millisecond,
 		},