chore: minor improvements: logging, comments, locks #1826
Annotations
10 errors and 4 warnings
Run golangci/[email protected]:
internal/mempool/mocks/mempool.go#L10
could not import github.com/dashpay/tenderdash/internal/mempool (-: # github.com/dashpay/tenderdash/internal/mempool
|
|
Run golangci/[email protected]:
internal/mempool/p2p_msg_handler.go#L98
undefined: time) (typecheck)
|
Run golangci/[email protected]:
internal/consensus/replay_stubs.go#L9
could not import github.com/dashpay/tenderdash/internal/mempool (-: # github.com/dashpay/tenderdash/internal/mempool
|
|
Run golangci/[email protected]:
internal/mempool/p2p_msg_handler.go#L98
undefined: time) (typecheck)
|
Run golangci/[email protected]:
internal/consensus/block_executor.go#L85
stateData.ProposalBlock undefined (type *StateData has no field or method ProposalBlock) (typecheck)
|
Run golangci/[email protected]:
internal/consensus/block_executor.go#L86
stateData.ProposalBlockParts undefined (type *StateData has no field or method ProposalBlockParts) (typecheck)
|
Run golangci/[email protected]:
internal/consensus/block_executor.go#L90
stateData.CurrentRoundState undefined (type *StateData has no field or method CurrentRoundState) (typecheck)
|
Run golangci/[email protected]:
internal/consensus/block_executor.go#L103
stateData.CurrentRoundState undefined (type *StateData has no field or method CurrentRoundState) (typecheck)
|
Install BLS library
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: technote-space/get-diff-action@v6, actions/setup-go@v2, actions/checkout@v2, actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2, actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Run golangci/[email protected]:
internal/p2p/channel.go#L338
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it to match ^_ (revive)
|
Loading