chore: minor improvements: logging, comments, locks #1777
Annotations
7 errors and 4 warnings
golangci-lint:
internal/p2p/throttled_channel_test.go#L151
const `n` is unused (unused)
|
golangci-lint:
internal/statesync/reactor.go#L52
const `snapshotMsgSize` is unused (unused)
|
golangci-lint:
internal/statesync/reactor.go#L55
const `chunkMsgSize` is unused (unused)
|
golangci-lint:
internal/statesync/reactor.go#L58
const `lightBlockMsgSize` is unused (unused)
|
golangci-lint:
internal/statesync/reactor.go#L61
const `paramMsgSize` is unused (unused)
|
golangci-lint:
internal/consensus/msg_handlers.go#L188
func `logKeyValsWithError` is unused (unused)
|
golangci-lint
issues found
|
golangci-lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
golangci-lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: technote-space/get-diff-action@v6, actions/setup-go@v2, actions/checkout@v2, actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
golangci-lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2, actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
golangci-lint:
internal/p2p/channel.go#L338
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it to match ^_ (revive)
|