Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump bls-signatures to 1.3.3 #2238

Closed
wants to merge 1 commit into from

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Oct 10, 2024

Issue being fixed or feature implemented

This PR bumps the bls-signatures to 1.3.3.

What was done?

How Has This Been Tested?

tests

Breaking Changes

no

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Updated the bls-signatures dependency version to improve performance and security.

Copy link
Contributor

coderabbitai bot commented Oct 10, 2024

Walkthrough

The changes involve an update to the Cargo.toml file within the dpp package. Specifically, the version of the bls-signatures dependency has been changed from v1.3.1 to 1.3.3, while maintaining the same Git repository reference. This update is reflected in the [dependencies] section of the file, with no other alterations made to dependencies or configurations.

Changes

File Change Summary
packages/rs-dpp/Cargo.toml Updated bls-signatures dependency version from v1.3.1 to 1.3.3

Poem

In the meadow where rabbits play,
A version change brightens the day.
From v1.3.1 to 1.3.3,
Hopping forward, oh so free!
With each update, we leap and bound,
In code and joy, new paths are found! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7da5601 and 17c3961.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • packages/rs-dpp/Cargo.toml (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
packages/rs-dpp/Cargo.toml (1)

18-18: LGTM! Verify compatibility with the updated bls-signatures version.

The update of bls-signatures from v1.3.1 to 1.3.3 aligns with the PR objective and follows good practices:

  • It's a minor version bump, indicating backward-compatible changes.
  • The optional flag is maintained, preserving feature compatibility.
  • The change is isolated to this single line, as expected for a version bump.

To ensure the update doesn't introduce any unexpected issues, please run the following verification steps:

These steps will help confirm that the update is compatible with the existing codebase.

✅ Verification successful

Verified the bls-signatures dependency update to version 1.3.3 and its optional status.

The Cargo.toml file correctly reflects the update:

  • bls-signatures is set to tag = "1.3.3".
  • The dependency remains marked as optional.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the bls-signatures update doesn't break existing functionality

# Test: Check if the package builds successfully with the new dependency version
cargo build --manifest-path packages/rs-dpp/Cargo.toml

# Test: Run the test suite to ensure all tests pass with the new version
cargo test --manifest-path packages/rs-dpp/Cargo.toml

# Test: Check for any warnings or deprecation notices related to bls-signatures
cargo check --manifest-path packages/rs-dpp/Cargo.toml 2>&1 | grep -i "bls-signatures"

Length of output: 340


Script:

#!/bin/bash
# Description: Verify that bls-signatures dependency is updated to version 1.3.3 and is optional

ast-grep --lang toml --pattern $'
[dependencies]
bls-signatures = { git = "https://github.com/dashpay/bls-signatures", tag = "1.3.3", optional = true }
'

Length of output: 263


Script:

#!/bin/bash
# Description: Verify that the bls-signatures dependency is updated to version 1.3.3 and is optional in Cargo.toml

# Search for the specific dependency line using ripgrep
rg 'bls-signatures\s*=\s*\{\s*git\s*=\s*"https://github.com/dashpay/bls-signatures",\s*tag\s*=\s*"1\.3\.3",\s*optional\s*=\s*true\s*\}' packages/rs-dpp/Cargo.toml

Length of output: 267


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@QuantumExplorer QuantumExplorer added this to the v1.5.0 milestone Oct 14, 2024
@shumkov shumkov changed the base branch from v1.4-dev to v1.6-dev November 1, 2024 01:53
@lklimek
Copy link
Contributor

lklimek commented Nov 15, 2024

This PR will not be needed anymore if we merge #2257

@ogabrielides
Copy link
Collaborator Author

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants