fix!: limit will now decrease when subquery has no elements #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
When Querying Grovedb using subqueries and with a limit the limit would only decrease if the subquery actually had an item. However in most cases the limit is there to protect against very expensive queries.
The queries would be expensive because we could go through many many trees where the sub elements have no matches, hence the limit would not decrease and hence we would continue on the increasingly expensive query.
What was done?
Created an option to allow to decrease the limit by one per iteration if subqueries have no items on them.
How Has This Been Tested?
Updated tests and debugged to make sure it was working
Breaking Changes
Checklist:
For repository code-owners and collaborators only