New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support stale rates #545

Merged

Syn-McJ merged 1 commit into dashpay:develop from Syn-McJ:feat/stale-rates

May 21, 2024

Member

Syn-McJ commented May 19, 2024

Issue being fixed or feature implemented

Some changes are required to support stale rate reporting.

What was done?

Add error reporting to the fetchCompletion
Save last rates retrieval time
Add isVolatile field for more than 50% change in price within 7 days

How Has This Been Tested?

QA

Breaking Changes

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation

For repository code-owners and collaborators only

I have assigned this pull request to a milestone


          chore: refactoring to support stale rates

f4f631b

Syn-McJ requested a review from pankcuf

May 19, 2024 04:16

Syn-McJ self-assigned this

pankcuf approved these changes

View reviewed changes

Collaborator

pankcuf left a comment

LGTM

Syn-McJ merged commit 8e211b3 into dashpay:develop

1 of 6 checks passed

Syn-McJ deleted the feat/stale-rates branch

May 21, 2024 13:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet