backport: merge bitcoin#24794, #23524, #24902, #24915, #24916, #24929, #23506, #24840, #24982, partial bitcoin#25288 (lint backports: part 2) #6429
+1,675
−1,183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
Depends on backport: merge bitcoin#24778, #24766, #24849, #24844, #24853, #24895, #24802, #24932, partial bitcoin#23212, #23462 (lint backports) #6428
The introduction in
flake8-cached
forlint-python.sh
in dash#4807 was reverted as this logic wasn't going to be ported over to the Python replacement as theflake8-cached
repo has been archived since April 2023 (source) and we don't use it in CI through GitLab (build) or GitHub Actions (build).bitcoin#25288 has been marked as partial as the change of the glob pattern from
{mod_path}/lint-*
to{mod_path}/lint-*.py
as we still havelint-cppcheck-dash.sh
around (source) (and the originalcppcheck
linter upstream was removed in bitcoin#25091).A Python port of that linter would allow for completing bitcoin#25288.
Breaking Changes
None expected.
Checklist