refactor: implement minimal RelayInv which doesn't rely on m_connman #6427
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vast majority of usages of RelayInv don't use the minProtoVersion, we may as well have these not contribute to contention of m_nodes_mutex / use m_connman
UdjinM6
approved these changes
Nov 23, 2024
kwvg
approved these changes
Nov 25, 2024
knst
reviewed
Nov 25, 2024
| @@ -94,7 +94,8 @@ class PeerManager : public CValidationInterface, public NetEventsInterface | |||
| virtual void PushInventory(NodeId nodeid, const CInv& inv) = 0; | |||
|
|
|||
| /** Relay inventories to all peers */ | |||
| virtual void RelayInv(CInv &inv, const int minProtoVersion = MIN_PEER_PROTO_VERSION) = 0; | |||
| virtual void RelayInv(CInv &inv) = 0; | |||
There was a problem hiding this comment.
is it breaking change? It means that some messages can be send to peers even if version is lower than MIN_PEER_PROTO_VERSION... Will it work fine?
There was a problem hiding this comment.
Peers with a version lower than this are disconnected asap:
https://github.com/dashpay/dash/blob/develop/src/version.h#L19-L20
https://github.com/dashpay/dash/blob/develop/src/net_processing.cpp#L3447-L3452
Side note: this made me wonder what versions are used in RelayInv() calls and we might want to change this line https://github.com/dashpay/dash/blob/develop/src/net_processing.cpp#L3394 so that PostProcessMessage() would use the fast variant too:
- RelayInv(result.m_inventory.value(), MIN_PEER_PROTO_VERSION);
+ RelayInv(result.m_inventory.value());Can be done here or in a follow-up PR.
knst
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Vast majority of usages of RelayInv don't use the minProtoVersion, we may as well have these not contribute to contention of m_nodes_mutex / use m_connman
What was done?
new implementation of RelayInv which doesn't rely on m_connman
How Has This Been Tested?
See CI
Breaking Changes
Checklist: