Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move CInstantSendManager::AskNodesForLockedTx into PeerManager #6425

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Commits on Nov 22, 2024

  1. refactor: move CInstantSendManager::AskNodesForLockedTx into PeerManager

    **This does change the logic!** We no longer prioritize asking MNs. This is probably fine? I don't specifically recall why we wanted to ask MNs besides potentially that they may be higher performing or better connected? We can potentially restore this logic once we bring masternode connection logic into Peer
    
    Does also change logic, by short-circuiting once peersToAsk is full.
    
    This commit has the added benefit of reducing contention on m_nodes_mutex due to no-longer calling connman.ForEachNode not once but twice
    
    This may slightly increase contention on m_peer_mutex; but that should be an ok tradeoff for not only removing dependencies, but also reducing contention on a much more contested RecursiveMutex
    PastaPastaPasta committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    090ae92 View commit details
    Browse the repository at this point in the history